feat: resolve metadata type using file extension #750
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 37 +1
Lines 1003 1021 +18
Branches 100 104 +4
=========================================
+ Hits 1003 1021 +18 ☔ View full report in Codecov by Sentry. |
scolladon
force-pushed
the
feat/resolve-metadata-type-on-extension
branch
from
79bd304
to
4f99903
Compare
|
Hi @fedegiust, @jverelst & @jjulicher ! We have a first working implementation of the metadata detection based on the extension first ! Could you please help us in validating this feature ? If you are interested in the spec it is written here. The code currently handles all the special cases we have found so far. Even the one when we have the same extension but not the same metadata type because it is not contained in the same folder (one of the most tricky to make work with all the other cases) In order to test it locally, you can follow those steps and install this PR. Let us know, we will merge it soon and ship a new release asap |
scolladon
force-pushed
the
feat/resolve-metadata-type-on-extension
branch
3 times, most recently
from
df486c7
to
d29105a
Compare
There was a problem hiding this comment.
@scolladon As discussed, let's include this one (and #740 ) in a release candidate, to make it easier to test it extensively 😃
MetadataRepositoryImpl included fsUtils for a constant To avoid that, constants have been moved into their own file
scolladon
force-pushed
the
feat/resolve-metadata-type-on-extension
branch
from
d29105a
to
43792fa
Compare
|
Code Climate has analyzed commit 43792fa and detected 0 issues on this pull request. View more on Code Climate. |
|
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]Happy incremental deployment! |
Explain your changes
Allow to resolve metadata type using the file extension instead of the folder when possible.
Fallback is to use the folder extension for those types:
Does this close any currently open issues?
closes #642 #350